#13891: Default parameters for Graph.plot() and Graph.show()
---------------------------------+------------------------------------------
Reporter: ncohen | Owner: jason, ncohen, rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.7
Component: graph theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Punarbasu Purkayastha,
Sébastien Labbé
Authors: Nathann Cohen | Merged in:
Dependencies: #13862 | Stopgaps:
---------------------------------+------------------------------------------
Changes (by ncohen):
* status: needs_work => needs_review
Comment:
Soooooooooooo !
I just refolded them all to check where the missing line in `G.show()` was
coming from, to notice that I stupidly removed it myself in the "fourth
pass". Well.
* [attachment:trac_13891-fourth_pass.patch] is left unchanged, even if
what it does is stupid
* [attachment:trac_13891-fifth_pass.patch] fixes it, and also applies
Punarbasu's modification
* [attachment:trac_13891-bugfix.patch] removes the useless option in the
combinat/ directory.
And of course [attachment:trac_13891-all_in_one.patch] applies all that.
Now, to answer Sebastian's questions :
1) Fixed in [attachment:trac_13891-fifth_pass.patch], sorry for that, good
job noticing it as no doctest checks that `:-P`
2) Fixed in [attachment:trac_13891-bugfix.patch]
A) Noooooo idea on earth.
B) Yep. Because basically, `show` calls `plot`.
Well, if you like it, this "small patch that defines new default options"
can go `:-P`
Thanks for your help !!!
Nathann
Apply trac_13891-all_in_one.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13891#comment:46>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
