#11026: Add double clicking of sws files for Mac app
----------------------------------+-----------------------------------------
       Reporter:  iandrus         |         Owner:  iandrus                     
                         
           Type:  enhancement     |        Status:  needs_review                
                         
       Priority:  major           |     Milestone:  sage-5.7                    
                         
      Component:  user interface  |    Resolution:                              
                         
       Keywords:  mac app         |   Work issues:                              
                         
Report Upstream:  N/A             |     Reviewers:  Karl-Dieter Crisman, 
Nicholas Kirchner, John Palmieri
        Authors:  Ivan Andrus     |     Merged in:                              
                         
   Dependencies:                  |      Stopgaps:                              
                         
----------------------------------+-----------------------------------------

Comment (by iandrus):

 Replying to [comment:67 jhpalmieri]:
 > I see that warning plus a few others on 10.8:
 > {{{
 > /Users/.../sage-5.7.beta4/devel/ext-main/sage/ext/mac-
 app/AppController.m:413:52: warning: format specifies type 'unsigned
 short' but the argument has type 'int' [-Wformat]
 >                  [NSString stringWithFormat:@"%C", 0x2026]]]; // @"…"
 >                                               ~~   ^~~~~~
 >                                               %d
 > /Users/.../sage-5.7.beta4/devel/ext-main/sage/ext/mac-
 app/AppController.m:445:55: warning: format specifies type 'unsigned
 short' but the argument has type 'int' [-Wformat]
 >             sessionType ? sessionType : @"", command, 0x2026];
 >                                                       ^~~~~~
 > /Users/.../sage-5.7.beta4/devel/ext-main/sage/ext/mac-
 app/AppController.m:552:69: warning: format specifies type 'long' but the
 argument has type 'OSErr' (aka 'short') [-Wformat]
 >         NSLog(@"Unable to determine gestaltSystemVersionMajor:
 %ld",err);
 >                                                                ~~~  ^~~
 >                                                                %hd
 > /Users/.../sage-5.7.beta4/devel/ext-main/sage/ext/mac-
 app/AppController.m:557:69: warning: format specifies type 'long' but the
 argument has type 'OSErr' (aka 'short') [-Wformat]
 >         NSLog(@"Unable to determine gestaltSystemVersionMinor:
 %ld",err);
 >                                                                ~~~  ^~~
 >                                                                %hd
 > 4 warnings generated.
 > }}}

 These warnings (and the one noted by kcrisman) should be harmless.

 > Meanwhile, [http://sage.math.washington.edu/home/palmieri/misc/sage-
 Sage-testing-doubleclick-x86_64-Darwin.dmg here is a bdist] built on OS X
 10.8, if anyone wants to test it.

 Awesome, thanks.

 Replying to [comment:69 jhpalmieri]:
 > The sed problem is with the file
 `./Sage.app/Contents/Resources/English.lproj/InfoPlist.strings`. If I
 remove this from the sed command in `sage-bdist`, the error message goes
 away. On my system, while in the mac-app directory, after running `sage-
 bdist`:
 > {{{
 > $ file English.lproj/InfoPlist.strings
 > English.lproj/InfoPlist.strings: ASCII c program text
 > $ file
 build/Debug/Sage.app/Contents/Resources/English.lproj/InfoPlist.strings
 > build/Debug/Sage.app/Contents/Resources/English.lproj/InfoPlist.strings:
 Little-endian UTF-16 Unicode c program text
 > }}}
 > That last part looks suspicious to me. Indeed, if I run `sed` on the
 first file, it works fine, but if I run it on the second, I get "sed: RE
 error: illegal byte sequence". How hard is it to fix this?

 We can remove this.  The file is for localizing some of the strings, but
 we don't do that anyway.  It used to be that it was an xml plist file, but
 I guess they changed it to be a binary plist file in order to save space.
 The `^S` is an unrelated problem.

 I'm adding a patch fixing the warnings and removing the `^S`.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11026#comment:70>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to