#14054: Cythoned UniqueRepresentation
-----------------------------------------------+----------------------------
Reporter: SimonKing | Owner: tbd
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.8
Component: performance | Resolution:
Keywords: cython UniqueRepresentation | Work issues:
Report Upstream: N/A | Reviewers: Travis
Scrimshaw
Authors: Simon King | Merged in:
Dependencies: #14017 | Stopgaps:
-----------------------------------------------+----------------------------
Comment (by SimonKing):
Replying to [comment:20 SimonKing]:
> > The behaviour you are implementing is much easier to explain if you
don't override those cases: Then you can just say that `WithRichCmpById`
provides `__hash__`, `__eq__` and `__ne__`, period.
>
> OK.
>
> > I think `WithEqualityById` would make a better conceptual name that is
less dependent on the implementation, by the way.
>
> Good idea.
Note: I would not like the name "`WithCmpById`", because `cmp` relies on
`__cmp__` (which is not touched) even if `__richcmp__` exists.
> Replying to [comment:18 tscrim]:
> > Last thing for now, shouldn't we issue a deprecation warning for
`FastHashable_class` since it has changed locations?
>
> I think I introduced it. But when? Or what ticket? I don't think anyone
used it.
It was in #11900. We could of course keep it in
sage.categories.category_singleton, but I think that's not the right
place. Note that I remove the dependency of `CategorySingleton` on
`FastHashable_class`, because the new cythoned hash is slightly faster.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14054#comment:21>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
