#13387: Improve MonoDict and TripleDict data structures
----------------------------------+-----------------------------------------
Reporter: nbruin | Owner: Nils Bruin
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.8
Component: memleak | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Nils Bruin | Merged in:
Dependencies: #11521, #12313 | Stopgaps:
----------------------------------+-----------------------------------------
Changes (by nbruin):
* type: enhancement => defect
* work_issues: rebase =>
Old description:
> On #715 and #12313 some variants of WeakKeyRef data structures are
> introduced, used in caching for, among other things, uniqueness of
> parents and coercions. In
> [http://trac.sagemath.org/sage_trac/ticket/12313#comment:162 #12313
> comment 162] is some data on how these data structures can be improved.
>
> '''Apply:'''
>
> - [attachment:trac_13387-combined-rel5.8.b0.patch] on top of
> sage-5.8.beta0
> - [attachment:trac_13387-guard_GC.patch]
New description:
On #715 and #12313 some variants of WeakKeyRef data structures are
introduced, used in caching for, among other things, uniqueness of parents
and coercions. In
[http://trac.sagemath.org/sage_trac/ticket/12313#comment:162 #12313
comment 162] is some data on how these data structures can be improved.
'''Apply:'''
- [attachment:trac_13387-combined.patch]
- [attachment:trac_13387-guard_GC.patch]
--
Comment:
I don't see why you think rebasing is necessary. The previous patchbot
logs already show that the ticket here applies cleanly on 5.8beta0 and
that tests pass.
The fact that #12313 fails to apply with its currently stated dependencies
is expected: The patchbot doesn't understand "merge with". However, if
patches apply here and tests pass, that's an implicit validation of #12313
(with the understanding that this ticket needs to be merged after it).
I'm also refiling this as a "defect" rather than an enhancement: Some of
the fixes here fix real bugs (although we might not have seen them
triggered).
Let's try again, since the "guard_GC" patch didn't get picked up by the
bot before:
Apply trac_13387-combined.patch trac_13387-guard_GC.patch
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13387#comment:47>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
