#13387: Improve MonoDict and TripleDict data structures
----------------------------------+-----------------------------------------
Reporter: nbruin | Owner: Nils Bruin
Type: defect | Status: positive_review
Priority: major | Milestone: sage-5.8
Component: memleak | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: Simon King
Authors: Nils Bruin | Merged in:
Dependencies: #11521, #12313 | Stopgaps:
----------------------------------+-----------------------------------------
Changes (by SimonKing):
* status: needs_review => positive_review
* reviewer: => Simon King
Comment:
With sage-5.8.beta0 plus #14159 plus #12313 plus #13387, make ptest works
fine for me. The ideas behind the patches from here are well-documented in
comments in the code. The precautions taken to prevent trouble with
garbage collection happening in the wrong moment seem reasonable to me.
And we have seen that the performance is fine as well.
Hence, it is a positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/13387#comment:51>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
