#14168: Fix race condition rebuilding MPIR,... with GCC spkg
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: GeorgSWeber
Type: defect | Status: needs_review
Priority: blocker | Milestone: sage-5.8
Component: build | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by leif):
Replying to [comment:5 jdemeyer]:
> Replying to [comment:1 leif]:
> > Regarding useless rebuilds, doesn't `sage-spkg mpir` (e.g.) always
`touch` `spkg/installed/mpir-...`
> On second thought, this actually is not a problem. What I overlooked is
that `make` simply will not run `sage-spkg mpir` if mpir is up-to-date. My
patch still respects make dependencies, I cannot think of a situation
where my patch would cause more packages to be built than necessary.
Ok, it doesn't cause ''more'' rebuilds than now, but...
Imagine (just) zlib got upgraded, and GCC gets (re)built: Then any spkg
(directly or indirectly) depending on any of MPIR, MPFR or MPC will also
get rebuilt. (You may argue that if GCC got rebuilt, it's "ok" or
"necessary" to rebuild the rest as well, but compare this to the situation
when Sage's GCC is ''not'' installed/used...)
Anyway, the patch here fixes the race condition ''with Sage's GCC''
(although actually only small parts of the `make install` of MPIR, MPFR
and MPC are critical, and the race conditions can still happen with "non-
Sage" GCCs).
So if Karl-Dieter is happy (and doesn't object), I'd reluctantly say
"positive review"...
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14168#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
