#14159: Don't install callbacks on values of TripleDict, MonoDict
----------------------------------+-----------------------------------------
       Reporter:  nbruin          |         Owner:  tbd         
           Type:  defect          |        Status:  needs_review
       Priority:  major           |     Milestone:  sage-5.8    
      Component:  memleak         |    Resolution:              
       Keywords:                  |   Work issues:              
Report Upstream:  N/A             |     Reviewers:  Nils Bruin  
        Authors:  Simon King      |     Merged in:              
   Dependencies:  #13387, #14254  |      Stopgaps:              
----------------------------------+-----------------------------------------

Comment (by nbruin):

 Replying to [comment:49 SimonKing]:
 > Question: Shall we remove the new function signed_id introduced in
 #14254? It is not needed with the approach that we take here.
 Alternatively, we could apply it. How much is the overhead of calling a
 cpdef inline function doing `<Py_ssize_t><void *>(x)`, compared without
 doing it directly?

 It's `inline`, so using it in a place where the `cdef` part is used should
 be 0 overhead. The `inline` should get expanded before the optimizer even
 looks at the code. The whole point of `inline` is to get the performance
 of `#define` macros without the headaches.

 If the function is not really in the way, it may be worth keeping around.
 I have found it immensely useful for debugging `cython` code if as much
 features as possible are also exposed in python. In particular, the `cdef`
 only data attributes can be a real pain.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14159#comment:51>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to