#14159: Don't install callbacks on values of TripleDict, MonoDict
----------------------------------+-----------------------------------------
       Reporter:  nbruin          |         Owner:  tbd            
           Type:  defect          |        Status:  positive_review
       Priority:  major           |     Milestone:  sage-5.9       
      Component:  memleak         |    Resolution:                 
       Keywords:                  |   Work issues:                 
Report Upstream:  N/A             |     Reviewers:  Nils Bruin     
        Authors:  Simon King      |     Merged in:                 
   Dependencies:  #13387, #14254  |      Stopgaps:                 
----------------------------------+-----------------------------------------
Changes (by nbruin):

  * status:  needs_review => positive_review


Comment:

 Good stuff! Much cleaner. Patchbot is happy and effectively this patch
 consolidates some use of `TripleDict` that was already in ad-hoc use, so
 there is not too much chance for unexpected failures. The solution here
 does solve the "manual" installation of callbacks that was dangerous
 before and in includes a sanity check that the object on which the
 callback is happening is indeed still referring to the (now dead) weakref
 that is causing the callback.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14159#comment:55>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to