#14055: Fix sage-cleaner
----------------------------------+-----------------------------------------
Reporter: jdemeyer | Owner: leif
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-5.9
Component: scripts | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers: John Palmieri, Leif
Leonhardy
Authors: Jeroen Demeyer | Merged in:
Dependencies: | Stopgaps:
----------------------------------+-----------------------------------------
Comment (by leif):
Replying to [comment:40 jhpalmieri]:
> Here is my view on this ticket:
>
> - `sage-cleaner` used to be completely broken.
I actually didn't have problems with it recently (more precisely, for
meanwhile a few years), until 5.9.x.
> - this ticket mostly fixes it.
> - the only flaw I see is a [comment:24 race condition], but that looks
pretty rare. Fixing it can wait.
Agreed, although I haven't closely looked at that yet. (It's pretty clear
that there is a race condition, but I'm not sure how likely it is in
practice.)
> - there are undoubtedly other ways in which `sage-cleaner` could be
fixed up, but they can wait.
>
> So I'm willing to give this a positive review. Any dissenting views?
Hmmm, ''in principle^TM^'' the Sage cleaner (with the patches from here)
should have killed the ECL processes, but Andrey reported it did not, so
(regardless of #12426) something seems to be still broken.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14055#comment:41>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
