#7477: Matroids
----------------------------------------------------+-----------------------
Reporter: ncohen | Owner: jkantor
Type: enhancement | Status:
needs_review
Priority: major | Milestone: sage-5.10
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Stefan van Zwam, Rudi Pendavingh | Merged in:
Dependencies: | Stopgaps:
----------------------------------------------------+-----------------------
Comment (by ncohen):
Hellooooooooooo again !
Well, I've been spending some time on that code, and I first have to say
that it is awfully clean. I was a bit afraid that something developped
outside of Sage would be more combinat-like, and that is not the case at
all here.
The other thing is that, stupid as it may seem, I had not realized until a
couple of minutes that I cannot realistically review 21 000 lines of code
by myself. I mean, with a real job that I have to do, with 3 meals per
day, everything. Looks complicated. This is one of the problems of
developping everything for a while then trying to create a single patch
out of it.
I will be glad to spend time on that, and also to work with the code
later, but yep, I guess that I cannot review 21 000 lines of code `:-)`
I think that in this case, as the code looks preeeeetty clean and all, the
best would really be to ask on sage-devel whether :
1) We take it in without a review (as if it were a spkg, actually)
2) Somebody (or many persons) are willing to review it together
Perhaps it would also help if you were to say in your message how you
produced this code. If many persons wrote that code, if many tried it...
I think that I can't do more. Otherwise, I know that I will not set this
to "positive review" before I am convinced that every single choice is a
good one, or at least having asked about it. And after having thought for
a while about each line, wondering if it is the best way to do it. I
already spent weeks on easier reviews, and I know that I cannot do that
one `:-)`
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7477#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
