#7477: Matroids
----------------------------------------------------+-----------------------
Reporter: ncohen | Owner: jkantor
Type: enhancement | Status:
needs_review
Priority: major | Milestone: sage-5.10
Component: combinatorics | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Stefan van Zwam, Rudi Pendavingh | Merged in:
Dependencies: | Stopgaps:
----------------------------------------------------+-----------------------
Comment (by darij):
Thanks for the answers! As for the maximizing bases, I just wanted a True
or False; that alone should not be expensive.
I shouldn't be burdening you with additional work; I would normally be
adding those methods myself if it wasn't for cython (the bitsets scared me
as well, but that turned out to be unfounded). If you want people to add
functionality, maybe you could document the internal functions better,
such as {{{__move_current_basis}}} (not obvious from the title what it
does; the same function with only 1 underscore is well-documented), and
explain what the pattern behind 2 underscores vs. 1 underscores is (I
guess 2-underscore functions take bitsets as input whereas 1-underscore
ones use python types?). The doc of {{{nxksrd}}} is too brief; it suggests
that the function returns the next k-subset, while apparently what it does
is transforming the k-subset in place and returning something that is more
like an error code. But take these suggestions with a grain of salt, as
I'm not exactly an experienced programmer...
A few things you might still want to fix (sorry for not mentioning them
earlier):
- You write {{{# the engine}}} twice in {{{basis_exchange_matroid.pyx}}}
(once on line 199 and again on line 276). A bit confusing ;)
- The docstring of method {{{_with_coloop}}} incorrectly states that the
input is "Nothing".
- Typos "succesively" and "distinguised".
On an unrelated note: WTF our finite field matrices use floating-point
algorithms???
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7477#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
