#7477: Matroids
----------------------------------------------------+-----------------------
       Reporter:  ncohen                            |         Owner:  jkantor   
  
           Type:  enhancement                       |        Status:  
needs_review
       Priority:  major                             |     Milestone:  sage-5.10 
  
      Component:  combinatorics                     |    Resolution:            
  
       Keywords:                                    |   Work issues:            
  
Report Upstream:  N/A                               |     Reviewers:            
  
        Authors:  Stefan van Zwam, Rudi Pendavingh  |     Merged in:            
  
   Dependencies:                                    |      Stopgaps:            
  
----------------------------------------------------+-----------------------

Comment (by ncohen):

 This review will take a lifetime, but right now all I can say is that the
 code of `circuits`, `cocircuits`, `noncospanning_cocircuits`, and
 `nonspanning_circuits` look awfully similar.

 And there are some parts of the code that are commented out, like that
 {{{
 +# def bitset_pickle_test(data):
 +#     """
 +#     Converts the list of integers ``data`` into a bitset, which gets
 pickled.
 +#     """
 +#     cdef bitset_t bs
 +#     m = max(data)
 +#     bitset_init(bs, m+1)
 +#     bitset_clear(bs)
 +#     for i in data:
 +#         bitset_add(bs, i)
 +#     p = bitset_pickle(bs)
 +#     bitset_free(bs)
 +#     return p
 }}}
 Or 4 functions in the matroid catalog.

 Nathann

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7477#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to