#5566: [with patch, needs some work] Symmetric Groebner bases and Infinitely
Generated Polynomial Rings
---------------------------------+------------------------------------------
Reporter: SimonKing | Owner: SimonKing
Type: enhancement | Status: new
Priority: major | Milestone: sage-3.4.2
Component: commutative algebra | Keywords: Symmetric Ideal
---------------------------------+------------------------------------------
Comment(by malb):
'''Review'''
* this patch should go in soon, because it is quite big already
* please document the parameters for {{{InfinitePolynomial.__init__}}
* note that {{{__foo__}}} functions are not included in the docs, so I
guess the {{{__init__}}} docs should be class level docs.
* please don't use {{{__repr__}}} and friends in doctests but use
examples that are natural Python and mark them {{{#indirect doctest}}}
* please fill in the 32-bit hash doctest values
* why do you ask coercion questions in {{{_add_}}} and friends, at this
point coercion should be done. What am I missing?
* most of the code is beautifully documented! Well done.
* you should add an {{{AUTHORS}}} block and add your name to each file
* the {{{INPUT}}} syntax is that each entry starts with a {{{-}}} not a
{{{*}}}
* at the risk of being obnoxious: the Python convention is to use
{{{add_generator}}} over {{{AddGenerator}}}
* I cannot vouche for the mathematics but it all seems very sound.
* Did you generate and check the docs?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5566#comment:23>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
