#9880: Pynac comparison functions do not provide a SWO
------------------------------------------------------------------+---------
Reporter: jpflori |
Owner: burcin
Type: defect |
Status: needs_review
Priority: major |
Milestone: sage-5.10
Component: symbolics |
Resolution:
Keywords: pynac | Work
issues:
Report Upstream: N/A |
Reviewers: Burcin Erocal, Jean-Pierre Flori
Authors: Burcin Erocal, Jean-Pierre Flori, Volker Braun | Merged
in:
Dependencies: #13213 |
Stopgaps:
------------------------------------------------------------------+---------
Comment (by burcin):
Replying to [comment:81 jpflori]:
> Thanks Burcin!
> I was finally going to do it today, but you were faster than me.
> At least I can give it a try on beta4 and check there is nothing else to
fix (all other patches apply cleanly.
>
> I'd really like other people (let's say at least one) to have a look at
the new order before you finalize 3.0 (or if it's already finalized/tagged
in your repo make a 3.1 or 3.0.1) in case we want to make minimal changes.
I agree. This is the reason I set this ticket to needs review even though
it was failing tests all over the library. :)
I tagged the 0.3.0 release already, but I can easily make a 0.3.1 if
necessary.
> E.g. I don't reallylike the following, but do not really mind as well:
> Replying to [comment:77 jpflori]:
> > The only thing which may be a little distrubing is that now we print
> > {{{
> > (2*x+1)*x^2
> > }}}
> > rather than
> > {{{
> > x^2*(2*x+1)
> > }}}
> >
> > This should be easily fixed in pynac hopefully, but even if not I
don't think it should be a blocker.
> But it would be really better to make these changes, if we plan to make
them, before merging the ticket, so that people preparing books (I'm
thinking of the french book which is in the process of being published)
can expect their examples to pass for a quite long amount of time (or at
least not to fail in the next version of Sage).
Feel free to submit patches to pynac with necessary changes. I don't have
time to work on this any more right now, but I can spare some minutes to
make a new release with simple patches.
That said, I'd really like this ticket to go in as soon as possible. It
really is not fun to maintain the patch with the doctest fixes.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9880#comment:82>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
