#14660: Improper error messages for semidirect products of permutation groups
--------------------------------+-------------------------------------------
Reporter: rbeezer | Owner: joyner
Type: defect | Status: needs_review
Priority: minor | Milestone: sage-5.10
Component: group theory | Resolution:
Keywords: | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Rob Beezer | Merged in:
Dependencies: | Stopgaps:
--------------------------------+-------------------------------------------
Changes (by {'newvalue': u'Rob Beezer', 'oldvalue': ''}):
* cc: khalasz, benjaminfjones, dshurbert (added)
* status: new => needs_review
* author: => Rob Beezer
Old description:
> The error messages for the semidirect product of permutation groups are
> '''returned''' rather than being '''raised'''. Ideally, these would have
> been caught on #13375. Mea culpa.
New description:
The error messages for the semidirect product of permutation groups are
'''returned''' rather than being '''raised'''. Ideally, these would have
been caught on #13365. Mea culpa.
'''Apply''':
1. [attachment:trac_14660-semidirect-error-messages.patch]
--
Comment:
While fixing the error messages, I've tidied up a few other things.
1. Error messages have been changed to being raised, and associated tests
adjusted accordingly.
1. Added a check on the first argument being a permutation group. And an
associated test as a result.
1. The loop {{{for alpha in mapping[1]:}}} has been rearranged slightly
to pull out some computations that can be done outside of the loop.
Strings and string formatting have been used to make the purpose of the
loop clearer, along with how GAP commands are being employed.
1. Use of {{{.format()}}} in a few places where strings are created (near
the end of the code).
1. Some minor formatting and spelling as I ran across them.
1. All tests in the sage and doc directories pass on 5.10.beta5.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/14660#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
