#2114: Get gf2x version 1.1 into Sage!
-------------------------------------+--------------------------------------
Reporter: was | Owner: somebody
Type: defect | Status: needs_work
Priority: major | Milestone: sage-5.10
Component: basic arithmetic | Resolution:
Keywords: spkg gf2x | Work issues:
Report Upstream: N/A | Reviewers:
Authors: Jean-Pierre Flori | Merged in:
Dependencies: | Stopgaps:
-------------------------------------+--------------------------------------
Comment (by zimmerma):
while trying gf2x-1.1 on my laptop, I hit a bug due to the fact that the
tuning gave
{{{GF2X_MUL_TOOM4_ALWAYS_THRESHOLD=16}}}, whereas a value at least 30 is
required.
The following patch will avoid this problem (or detect it earlier). It is
against the development version but should be easily adapted to 1.1:
{{{
--- toom.c (revision 148)
+++ toom.c (working copy)
@@ -1,6 +1,6 @@
/* This file is part of the gf2x library.
- Copyright 2007, 2008, 2009
+ Copyright 2007, 2008, 2009, 2013
Richard Brent, Pierrick Gaudry, Emmanuel Thome', Paul Zimmermann
This program is free software; you can redistribute it and/or modify
it
@@ -53,6 +53,9 @@
if (n < GF2X_MUL_TOOMW_THRESHOLD)
return GF2X_SELECT_KARA; // KarMul
+#if GF2X_MUL_TOOM4_ALWAYS_THRESHOLD < 30
+#error "GF2X_MUL_TOOM4_ALWAYS_THRESHOLD must be >= 30"
+#endif
if (n >= GF2X_MUL_TOOM4_ALWAYS_THRESHOLD)
return GF2X_SELECT_TC4; // Toom4Mul
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/2114#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
