#5765: [with patch, needs review] improve doctest coverage for
schemes/generic/algebraic_scheme.py
--------------------------------+-------------------------------------------
Reporter: AlexGhitza | Owner: AlexGhitza
Type: defect | Status: assigned
Priority: major | Milestone: sage-3.4.2
Component: algebraic geometry | Keywords: doctest algebraic scheme
--------------------------------+-------------------------------------------
Comment(by AlexGhitza):
I was working on rebasing the patch against 3.4.2.alpha0, when I realised
that {{{ell_field.py}}} has no reason to implement
{{{_check_satisfies_equations}}}, since I have fixed the corresponding
function "upstream" in {{{algebraic_scheme.py}}}. In other words, the
inherited method now works as it should so there's no need to reimplement
it for elliptic curves.
Of course, once you remove {{{_check_satisfies_equations}}} from
{{{ell_field.py}}}, there's nothing left. I think we just just get rid of
this file and make classes that currently inherit from
{{{EllipticCurve_field}}} inherit directly from
{{{EllipticCurve_generic}}} instead.
The newly attached patch {{{trac_5765-rebased.patch}}} implements all
this, and is based on 3.4.2.alpha0. Doctests pass for me, but this is a
significant change so I'd like John to review this so he can object if
need be.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5765#comment:14>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
