#5765: [with new patch, needs review] improve doctest coverage for
schemes/generic/algebraic_scheme.py
--------------------------------+-------------------------------------------
Reporter: AlexGhitza | Owner: AlexGhitza
Type: defect | Status: assigned
Priority: major | Milestone: sage-4.0
Component: algebraic geometry | Keywords: doctest algebraic scheme
--------------------------------+-------------------------------------------
Comment(by cremona):
The new patch replaces the first one and deals with this. (Sorry, I
forgot to do "sage -hg qnew" so it is not a separate patch,
The problem was: in ell_field.py the function _check_satisfies_equations
called _error_bad_coords which Alex had renamed. But all it did was riase
an error with an appropriate message, so I just raised the error in place.
One remaining question: why is the error raised a TypeError? In my view
the type is fine but the values are wrong if the coordinates do not
satisfy the equation. I would have made it a ValueError. but for
consistence with the general scheme functions I left it as a TypeError.
I put this back to "needs review" but if Michael is happy with test
passing there's no more needed.
John
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5765#comment:8>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
