#5765: [with patch, needs review] improve doctest coverage for
schemes/generic/algebraic_scheme.py
--------------------------------+-------------------------------------------
Reporter: AlexGhitza | Owner: AlexGhitza
Type: defect | Status: assigned
Priority: major | Milestone: sage-3.4.2
Component: algebraic geometry | Keywords: doctest algebraic scheme
--------------------------------+-------------------------------------------
Comment(by AlexGhitza):
The attached patch brings up the doctest coverage from 24% to 87% (29 of
33).
There is also some fairly straightforward refactoring of code, e.g. moving
{{{_validate}}} to the ambient spaces where it belongs logically. I also
realised that {{{self.complement(other)}}} is counterintuitive and changed
it to match normal speech patterns: it should be "the complement of self
in other", which is other-self, not self-other. An added bonus is that
now one can write {{{X.complement()}}} to get the complement of X in its
ambient space, which is highly intuitive. Normally such a change in
behaviour would be tricky but since the functions were just broken until
3.4.1.rc3, this shouldn't lead to any confusion (since nobody has used
them yet).
Note that the patch relies on changes that only went in at 3.4.1.rc3, so
it should only be applied on top of 3.4.1.rc3.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/5765#comment:4>
Sage <http://sagemath.org/>
Sage - Open Source Mathematical Software: Building the Car Instead of
Reinventing the Wheel
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
