#15184: CachedFunction file location seems problematic
--------------------------+-------------------------
Reporter: nbruin | Owner:
Type: defect | Status: new
Priority: major | Milestone: sage-5.12
Component: misc | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
--------------------------+-------------------------
Comment (by nbruin):
Replying to [comment:2 SimonKing]:
> I think the current code is fragile, in particular if soft links are
used (os.path.realpath might be needed at some point).
Do you think so? Shouldn't we just trust the paths as they are offered to
us? Either `$SAGE_ROOT` has already been normalized, and then at this
point any path that's coming from sage is already a "real" path, or
`$SAGE_ROOT` is not normalized (and hence nothing derived from it either)
and we shouldn't be normalizing either.
> The proposed fix expects the path separator "/", which should be
os.path.pathsep.
>
> So, there is enough reason to use os.path, rather than re-inventing its
functionality in a non-portable way.
I agree with that. However, I don't really see why we need to fondle the
path anyway. We're getting the path that would be generated by
`sage_getfile` on the original function. How can we improve on that?
--
Ticket URL: <http://trac.sagemath.org/ticket/15184#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
