#15184: CachedFunction file location seems problematic
--------------------------+-------------------------
       Reporter:  nbruin  |        Owner:
           Type:  defect  |       Status:  new
       Priority:  major   |    Milestone:  sage-5.12
      Component:  misc    |   Resolution:
       Keywords:          |    Merged in:
        Authors:          |    Reviewers:
Report Upstream:  N/A     |  Work issues:
         Branch:          |       Commit:
   Dependencies:          |     Stopgaps:
--------------------------+-------------------------

Comment (by SimonKing):

 Replying to [comment:3 nbruin]:
 > > So, there is enough reason to use os.path, rather than re-inventing
 its functionality in a non-portable way.
 >
 > I agree with that. However, I don't really see why we need to fondle the
 path anyway. We're getting the path that would be generated by
 `sage_getfile` on the original function. How can we improve on that?

 Python does not provide the file information in the doc string, but Cython
 does. And what would Cython do?
 {{{
 sage: CachedFunction.__doc__
 "File: sage/misc/cachefunc.pyx (starting at line 452)\n\n
 ...
 }}}

 I guess we try to mimmick this behaviour. Note, however, that we mildly
 fail:
 {{{
 sage: P.<x,y> = QQ[]
 sage: I = P*x
 sage: from sage.misc.sageinspect import _sage_getdoc_unformatted
 sage: _sage_getdoc_unformatted(I.groebner_basis)
 "File: /sage/rings/polynomial/multi_polynomial_ideal.py (starting at line
 3507)
 ...
 }}}
 So, there is the additional "/" in the beginning of the file location. But
 in any case, Cython does not give the full path, and thus it should be a
 good idea that Sage doesn't, either.

 By the way, something that I'm perhaps not to blame for should be changed,
 too: `sage.misc.cachefunc.FileCache` uses '/' as separator.

--
Ticket URL: <http://trac.sagemath.org/ticket/15184#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to