#15184: CachedFunction file location seems problematic
--------------------------+----------------------------
Reporter: nbruin | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.12
Component: misc | Resolution:
Keywords: | Merged in:
Authors: | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
--------------------------+----------------------------
Comment (by SimonKing):
Replying to [comment:5 nbruin]:
> Something along these lines then?
Sounds good! And thank you that you did not attach a git branch. Hence,
there is a chance that I will actually review it soon. Hopefully some
people at Sage Days in Oxford will explain how to work with git. It
currently seems plainly broken to me.
> Note that this may be a good motivation to refactor sageinspect a
little, so that getting "source file and line" is a little cheaper in many
cases.
How?
> Getting just a docstring should be fairly cheap (and usually should not
involve reading source files),
Yes, the docstring itself would be easy. But in order to comply with
Cython, it was decided to put file information into the doc string.
> and here we're usually triggering a full fetch of the source code, only
to throw it away.
What do you mean by "here"?
> The reason is that sage_getsourcelines has a lot of logic that also
applies to just fetching (file,lineno), but that logic is not available
separately.
Is there code duplication? Or do you just suggest to make the code more
modular?
--
Ticket URL: <http://trac.sagemath.org/ticket/15184#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
