#15149: Bug in pickling of toric varieties, II
-------------------------------------+-------------------------------------
       Reporter:  jkeitel            |        Owner:
           Type:  defect             |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.0
      Component:  algebraic          |   Resolution:
  geometry                           |    Merged in:
       Keywords:  toric              |    Reviewers:  Volker Braun
        Authors:                     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  15a41647c634421769963f6b6ccabe65c7907789
  u/jkeitel/toric_pickling_2         |     Stopgaps:
   Dependencies:  #15050             |
-------------------------------------+-------------------------------------
Changes (by vbraun):

 * status:  needs_info => positive_review


Comment:

 The only thing in !ToricVariety that refers back to itself are caches, if
 it weren't for that it would be perfectly safe to pickle it by its dict. I
 don't think its a good solution to have everybody write a custom pickling
 just to manually exclude caches.

 Also, all the changes in the attached branch are desirable anyways, so we
 should include them. Any further discussion of general frameworks for
 pickling should go elsewhere (perhaps #15156).

--
Ticket URL: <http://trac.sagemath.org/ticket/15149#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to