#15149: Bug in pickling of toric varieties, II
-------------------------------------+-------------------------------------
Reporter: jkeitel | Owner:
Type: defect | Status: new
Priority: major | Milestone: sage-6.0
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: toric | Reviewers: Volker Braun
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: | 15a41647c634421769963f6b6ccabe65c7907789
u/jkeitel/toric_pickling_2 | Stopgaps:
Dependencies: #15050 |
-------------------------------------+-------------------------------------
Changes (by vbraun):
* reviewer: => Volker Braun
Comment:
For the record, with this ticket the `loads(dumps(variety.Todd_class()))`
works and without this ticket it fails miserably. Its really the caching
that messes us up, because it puts additional circular references into the
reduction without any user control. Except for disabling it via
`ClearCacheOnPickle` mixin class or by overriding `__reduce__`. I still
think we should make pickling of caches opt-in and not opt-out, because it
is very easy to trip over and hard to doctest different combinations of
cached outputs. If you want to pickle some result then just pickle the
result, not the object that happens to cache the result.
But, in any case, this is not material for this ticket. The solution looks
good within the constraints of the current caching system, so positive
review.
--
Ticket URL: <http://trac.sagemath.org/ticket/15149#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
