#15315: aspect ratio ignored in matrix and density plots
-------------------------------------------------+-------------------------
       Reporter:  kcrisman                       |        Owner:
           Type:  defect                         |       Status:
       Priority:  major                          |  needs_review
      Component:  graphics                       |    Milestone:  sage-5.13
       Keywords:  matplotlib imshow density      |   Resolution:
  plot                                           |    Merged in:
        Authors:  Punarbasu Purkayastha          |    Reviewers:  Karl-
Report Upstream:  N/A                            |  Dieter Crisman
         Branch:                                 |  Work issues:
   Dependencies:                                 |       Commit:
                                                 |     Stopgaps:
-------------------------------------------------+-------------------------

Comment (by kcrisman):

 This looks great in general, except it does change density and matrix
 plots to having the default aspect ratio be "automatic".  As a very gentle
 review request, could you remove the extra back tick from
 [http://hg.sagemath.org/sage-
 
main/src/f0ee3538887fe739601babb54e177ec5e1133b7a/sage/plot/density_plot.py?at=default#cl-45
 here]?  Same file.  You didn't introduce it but it would be nice not to
 open a separate ticket for that.

 As to aspect ratio, we just need to decide what we want.  Note that #12222
 changed most geometric figures to be "1" but other things to be auto, and
 then #12581 switched contour and region plots to "1".  Now we are
 suggesting changing density and matrix plots to be auto, not 1.  And what
 about slope/vector fields?  Historically we have kept such things at "1"
 because we figured the typical user would have them be squares.  But maybe
 that was wrong.  The canonical example is
 {{{
         sage: x,y = var('x,y')
         sage: contour_plot(x^2+y^2-2,(x,-1,1), (y,-1,1))
 }}}
 and we went with that being circles, not ellipses :)

 Jason, do you have any comments on this?  I would hate to change our
 defaults again and again; the most important thing here is allowing user
 control of the aspect ratio, so we could put in a decorator to keep these
 at aspect ratio 1 (though then ppurka would have to change the text of his
 test).

--
Ticket URL: <http://trac.sagemath.org/ticket/15315#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to