#15315: aspect ratio ignored in matrix and density plots
-------------------------------------------------+-------------------------
       Reporter:  kcrisman                       |        Owner:
           Type:  defect                         |       Status:
       Priority:  major                          |  needs_review
      Component:  graphics                       |    Milestone:  sage-5.13
       Keywords:  matplotlib imshow density      |   Resolution:
  plot                                           |    Merged in:
        Authors:  Punarbasu Purkayastha          |    Reviewers:  Karl-
Report Upstream:  Reported upstream. Developers  |  Dieter Crisman
  deny it's a bug.                               |  Work issues:
         Branch:                                 |       Commit:
   Dependencies:                                 |     Stopgaps:
-------------------------------------------------+-------------------------

Comment (by ppurka):

 Replying to [comment:10 kcrisman]:
 > That doesn't change that we should have the discussion about whether
 density plots should have automatic or 1 aspect ratio.  I don't exactly
 have a horse in the race, but I think that needless API changes are also
 annoying.

 About density plots: I think mpl is doing "the right thing" when aspect is
 set to auto. This is not a geometrical object, so I think there we should
 not have aspect 1 in all cases.

 About matrix plots: In this case, I think we should interpret an unset
 aspect ratio as `"equal"` aspect ratio. This is already set explicitly in
 the code currently but this should be handled better. The current patch
 affects the matrix plots and the images are no longer square.

 Other functions where aspect ratio is not set:

 * `arrow` - `FancyArrowPatch` from mpl has no aspect option
 * `bezier_path` - `Path` from mpl has no aspect option
 * `complex_plot` - the aspect ratio is not set in our code, and I think it
 is best left as automatic
 * `plot_field` - I don't see an aspect option in quiver of mpl
 * `step` - IMHO, there is no need for aspect ratio here
 * `text.py` - I think there is no need for aspect ratio here, and `text`
 in mpl has no such option either.

 So, the only thing this patch affects are the matrix plots, and I think
 there the code should explicitly set the aspect ratio, i.e., we should
 introduce either `@options(aspect_ratio=1)` or
 `@options(aspect_ratio="equal")` in the definition of `matrix_plot`.

--
Ticket URL: <http://trac.sagemath.org/ticket/15315#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to