#15315: aspect ratio ignored in matrix and density plots
-------------------------------------------------+-------------------------
Reporter: kcrisman | Owner:
Type: defect | Status:
Priority: major | needs_review
Component: graphics | Milestone: sage-5.13
Keywords: matplotlib imshow density | Resolution:
plot | Merged in:
Authors: Punarbasu Purkayastha | Reviewers: Karl-
Report Upstream: N/A | Dieter Crisman
Branch: | Work issues:
Dependencies: | Commit:
| Stopgaps:
-------------------------------------------------+-------------------------
Comment (by ppurka):
Replying to [comment:5 kcrisman]:
> This looks great in general, except it does change density and matrix
plots to having the default aspect ratio be "automatic".
This is the same as it was earlier! The aspect ratio is set to
`self.aspect_ratio()` if it is `None` (c.f. the patch). And the latter
returns `"automatic"` by default. So, if matrix and density plots have not
been setting the aspect ratio to one explicitly, then they ''are'' running
with `"automatic"` aspect ratio.
So, IMHO, for the plots where the aspect ratio is explicitly set to 1 by
`@options`, it remains 1. And for the plots where it is not automatically
set, `"automatic"` was already the default, so we are not changing
anything here.
> As a very gentle review request, could you remove the extra back tick
from [http://hg.sagemath.org/sage-
main/src/f0ee3538887fe739601babb54e177ec5e1133b7a/sage/plot/density_plot.py?at=default#cl-45
here]? Same file. You didn't introduce it but it would be nice not to
open a separate ticket for that.
Done.
--
Ticket URL: <http://trac.sagemath.org/ticket/15315#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
