#15303: Coercion discovery fails to be transitive
-------------------------------------+-------------------------------------
Reporter: nbruin | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: coercion | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: N/A | Work issues: Crash in permgroup.py
Branch: | Commit:
u/SimonKing/ticket/15303 | 528a03535447d67f04dc16d0a22cc38def54f9f1
Dependencies: #14711, #15329, | Stopgaps:
#15331 |
-------------------------------------+-------------------------------------
Changes (by SimonKing):
* status: needs_work => needs_review
Comment:
I think #13394 is working, and hence I merged #13394 into the branch of
this ticket. Before I pushed the changes, I did `make ptest`, and got
{{{
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 3859.6 seconds
cpu time: 6042.4 seconds
cumulative wall time: 7416.0 seconds
}}}
Hence: Replacing `weakref.WeakValueDictionary` by the newer safer faster
... `sage.misc.weak_dict.WeakValueDictionary` has been enough to solve the
problem with doctests crashing! So, I can put this to "needs review".
I just notice: With the branch from #15303, the total time for make ptest
is 4634.7 s (or 7269.1 CPU-s). With the branch from here, we are quite
noticeably faster. So, could it be that the new approach of representing
the dynamic coerce digraph is more efficient?
--
Ticket URL: <http://trac.sagemath.org/ticket/15303#comment:97>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
