#13394: Write a WeakValueDictionary with safer key removal
-------------------------------------+-------------------------------------
Reporter: nbruin | Owner: rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: memleak | Resolution:
Keywords: | Merged in:
Authors: Simon King, Nils | Reviewers: Simon King
Bruin | Work issues:
Report Upstream: None of the above | Commit:
- read trac for reasoning. | e60890eea7e9d108431d183c897b37482b12e4cf
Branch: | Stopgaps:
u/SimonKing/ticket/13394 |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by nbruin):
Some small type corrections and some major example changes for
`_IterationContext`: the examples were testing behaviour that the guard
doesn't influence in its current incarnation. I have replaced it with an
example that should also illustrate that people should really only use a
`WeakValueDictionary` if they really need that, because their behaviour
can be very strange (especially when the same objects occur as keys and
values)
I'd be OK with giving a positive review to "your part" and since you've
given a positive review to "my part" (provided you're OK with the changes
I've made) all code has a positive review. I think we've been pretty
careful in developing this code.
Would it be possible to "fold" the commits on the branch here? It would be
silly to document the little "back and forth" on some bits in the
"official" sage history.
--
Ticket URL: <http://trac.sagemath.org/ticket/13394#comment:81>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
