#13394: Write a WeakValueDictionary with safer key removal
-------------------------------------+-------------------------------------
Reporter: nbruin | Owner: rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: memleak | Resolution:
Keywords: | Merged in:
Authors: Simon King, Nils | Reviewers: Simon King
Bruin | Work issues:
Report Upstream: None of the above | Commit:
- read trac for reasoning. | e60890eea7e9d108431d183c897b37482b12e4cf
Branch: | Stopgaps:
u/SimonKing/ticket/13394 |
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Replying to [comment:81 nbruin]:
> I've attached some changes (both as a patch and the file that should be
the end result).
OK, I'll merge it into the branch.
> Would it be possible to "fold" the commits on the branch here? It would
be silly to document the little "back and forth" on some bits in the
"official" sage history.
I was told that changing a commit that is published on trac but is not
merged in Sage means "changing the history" (even though it will only be
merged in future) and is bad. I really hate this aspect of git. So, even
though I totally agree that documenting the back and forth is silly, I
will not fold.
--
Ticket URL: <http://trac.sagemath.org/ticket/13394#comment:82>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
