#15392: Implement minimal model algorithm
--------------------------------------+----------------------------
Reporter: bhutz | Owner: bhutz
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: algebraic geometry | Resolution:
Keywords: sage-days55 | Merged in:
Authors: bhutz | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
Dependencies: | Stopgaps:
--------------------------------------+----------------------------
Comment (by nbruin):
I've attached a "patch" with some suggested improvements. With that
version, I was able to check the minimality of `[eval(c) for c in
urllib.urlopen("http://www.cecm.sfu.ca/~nbruin/intorbits/deg2.txt";)]`
within a minute (that's a little over 2000 quadratic maps). I'm sure the
code could be optimized further, but why bother now? I don't think the
current code is doing anything outright silly any more and running `%prun`
on some examples produces for me a profile I can believe (most time is
spent in the recursive `blift`, which is what one would expect).
There's still the naming of the file and of the routines to be considered.
The code itself seems fine. I've run it by giving it (known) minimal maps
from the tables referred to above, conjugating by random transformations,
and seeing if the minimal model returned has the same resultant (up to
sign) as the original, and I didn't find problems.
(I noticed there's a doctest failing for `blift` now, but that's because
the test puts an integer in the input list where there should be
polynomials. I propose the doctest gets amended, since the internal use of
`blift` guarantees that the input consists of a list of polynomials.)
--
Ticket URL: <http://trac.sagemath.org/ticket/15392#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
