#15392: Implement minimal model algorithm
--------------------------------------+----------------------------
       Reporter:  bhutz               |        Owner:  bhutz
           Type:  enhancement         |       Status:  needs_review
       Priority:  major               |    Milestone:  sage-5.13
      Component:  algebraic geometry  |   Resolution:
       Keywords:  sage-days55         |    Merged in:
        Authors:  bhutz               |    Reviewers:
Report Upstream:  N/A                 |  Work issues:
         Branch:                      |       Commit:
   Dependencies:                      |     Stopgaps:
--------------------------------------+----------------------------

Comment (by bhutz):

 Those changes look good.

 I have thought about the naming and see your point on the file name.
 Although, I'm inclined to be optimistic for the future and call it
 `endPN_minimal_model`. This will also allow consistent naming for other
 algorithms for endomorphisms of PN.

 I'm also happy to call the function `is_PGL_minimal`.

 Yes. we should just update the doctest as well as we made our best guess
 as to what a reasonable test was for the individual functions.

 I can fold the patches together and make these changes unless you want to
 use your `referee` patch to do them?

--
Ticket URL: <http://trac.sagemath.org/ticket/15392#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to