#15278: Hash and equality for graphs
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/SimonKing/ticket/15278 | 2fc8a772ee12fce7ac6abc4ecf9916f4746f5ee2
Dependencies: #12601, #15491 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Replying to [comment:36 SimonKing]:
> Replying to [comment:35 ncohen]:
> > HMmmmmm okay. Though I really have no clue what the changes you made
to cachefunc.pyx do `O_o`
>
> Hein? My branch doesn't touch cachefunc.pyx at all! And why should it?
Ahaha, now I understand. That's this dreaded feature of the new git
workflow: The commits changing cachefunc.pyx belong to #12601, hence, to a
dependency of this ticket. But Volker believes that it is a good thing
that a reviewer also has a look at what happens in the dependencies.
Personally, I believe that #12601 has a positive review and provides a
feature that does not rely on graphs, but it is handy to use here. Hence,
I don't think your review of this ticket must comprise a second review of
#12601. Of course, if you happen to spot something in #12601 that doesn't
work then please speak up.
--
Ticket URL: <http://trac.sagemath.org/ticket/15278#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
