#15278: Hash and equality for graphs
-------------------------------------+-------------------------------------
Reporter: SimonKing | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-5.13
Component: graph theory | Resolution:
Keywords: | Merged in:
Authors: Simon King | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/SimonKing/ticket/15278 | 2fc8a772ee12fce7ac6abc4ecf9916f4746f5ee2
Dependencies: #12601, #15491 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Yooooooooooooo !!
> Hein? My branch doesn't touch cachefunc.pyx at all! And why should it?
Arggggg.. Well, i see modifications to cachefunc.pyx when I click on the
banch's name, in the description of this ticket, at the top of the page.
But that's from the dependency on #12601 it seems.
Looks like reviewing git branches with dependencies is going to be
painful. Especially since Volker didn't want to hear anything of what was
said on https://groups.google.com/d/topic/sage-git/ZC5QB1o1JlE/discussion
Sigh. Sorry for the misunderstanding :-/
> I don't even have a clue what you mean by "this". You have provided a
> "static" backend that is almost enough to produce immutable graphs. To
> really make them immutable (in the sense stated repeatedly), it was
needed
> to allow `G.weighted()` but disallow `G.weighted(new_value)` on
immutable
> graphs, since the latter would mutate the graph. And if something is
> immutable then it makes sense to provide it with a hash---which in the
> case of graphs means to provide the `._immutable` attribute---and to
make
> the hash faster (by using work on @cached_method that has already been
> done in #12601).
>
> So, that's what this ticket is about. Or is there anything I forgot?
Sorry sorry, it's just a misunderstanding about what this branch
contains... T_T
> And my next aim is to continue work on #12630. There, it is useful to
have
> hashable (immutable) (di)graphs that can be used as cache keys.
Okayyyyyyyyyyyyyyyyyyyyyyyyyyyyyy ! I thought that it was the case as soon
as these things were hashable, but if you say so O_o
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15278#comment:38>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
