#10963: More functorial constructions
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: stumpc5
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.1
Component: categories | Resolution:
Keywords: days54 | Merged in:
Authors: Nicolas M. Thiéry | Reviewers: Simon King, Frédéric
Report Upstream: N/A | Chapoton
Branch: | Work issues:
public/ticket/10963 | Commit:
Dependencies: #11224, #8327, | 0c907cf81efeb9bd2d0a44f73539c4e32583c1be
#10193, #12895, #14516, #14722, | Stopgaps:
#13589, #14471, #15069, #15094, |
#11688, #13394, #15150, #15506 |
-------------------------------------+-------------------------------------
Comment (by SimonKing):
Replying to [comment:216 tscrim]:
> Okay, I figured out the problem. The `weak_cached_function` was changed
to a `cached_function` for `CachedRepresentation.__classcall__()` in
`unique_representation.py`. IDK what impact this might have on the rest of
things with this patch, but it fixes the memory leak.
WHAT??????
I made `CachedRepresentation.__classcall__()` a `@weak_cached_function`
quite a long time ago, and I think I have also added doctests to show that
a weak cache is used. So, how could it be possible that such a change
almost went unnoticed?
`git blame` shows that this change has been done by Nicolas in revision
`9d9cae`, and
{{{
| | * | 362fd5e - # Tue Oct 29 20:14:19 2013 +0100 (vor 6 Wochen) <Nicolas
M. Thiery>
| | * | b2914f3 - # Sun Oct 27 13:58:49 2013 +0100 (vor 6 Wochen)
<Frederic Chapoton>
| | * | 9d9cae3 - # Sat Oct 19 11:50:04 2013 +0200 (vor 6 Wochen) <Nicolas
M. Thiery>
}}}
Why is there no proper commit message? Is this stuff from here? Have I
really been the reviewer of this change `:-\`?
I notice that there are further uses of `@cached_function` in the
changeset. So, I guess in the next round of review I need to take more
care of this point.
--
Ticket URL: <http://trac.sagemath.org/ticket/10963#comment:218>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
