#10963: More functorial constructions
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner: stumpc5
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-6.1
Component: categories | Resolution:
Keywords: days54 | Merged in:
Authors: Nicolas M. Thiéry | Reviewers: Simon King, Frédéric
Report Upstream: N/A | Chapoton
Branch: | Work issues:
public/ticket/10963 | Commit:
Dependencies: #11224, #8327, | 0c907cf81efeb9bd2d0a44f73539c4e32583c1be
#10193, #12895, #14516, #14722, | Stopgaps:
#13589, #14471, #15069, #15094, |
#11688, #13394, #15150, #15506 |
-------------------------------------+-------------------------------------
Changes (by SimonKing):
* status: needs_review => needs_info
Comment:
Replying to [comment:219 nbruin]:
> Replying to [comment:218 SimonKing]:
> > Why is there no proper commit message? Is this stuff from here? Have I
really been the reviewer of this change `:-\`?
>
> Yep ... It's right there at the end of [attachment:trac_10963
-more_functorial_constructions-nt.patch]
Argh. Sorry that I didn't notice it.
But why can this not have led to doctest failures before? I am sure that I
added doctests showing that `CachedRepresentation` uses a weak cache! Have
these tests been removed by the patch?
Something else (and this is a question to Volker, hence, "needs info"):
Why is there no proper commit message in the git log? I thought that `sage
--dev import-patch` would preserve the commit messages from the mercurial
patch.
And what shall we do about it? By git's idiosyncratic notion of history,
adding a proper commit message would imply a history change, and since
this branch is already in use by people, we can't change the history, it
would create merge conflicts, etc.
AFAIK, adding a commit message in the mercurial workflow was trivial,
since only the code matters for whether or not subsequent patches apply
cleanly.
--
Ticket URL: <http://trac.sagemath.org/ticket/10963#comment:222>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
