#15588: Cleanup of integer_mod_ring.py
-------------------------------------+-------------------------------------
Reporter: tscrim | Owner: tscrim
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-6.1
Component: doctest coverage | Resolution:
Keywords: | Merged in:
Authors: Travis Scrimshaw | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/rings/cleanup_integer_mod_ring|
0e1a46b94e5094921fe35561e75c9369d7cd7d92
Dependencies: #15369 | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => positive_review
* reviewer: => Nathann Cohen
Comment:
Ahahaahah. Funny. I barely know what all these functions do, though I was
always able to check that the code was equivalent to what it was
previously. Sooooooo it's all good.
Even though we don't agree on style issues. It looks like you prefer to
have many "if/return, if/return,if/return" while I prefer "elif/return",
and for some reason you don't like "else" at all.
Ahahaah. Anyway, it's good to go, thank you for that !
And I have to read this awful thing soon, for I can't go on having to
complain each time the categories are involved.
http://www.sagemath.org/doc/reference/categories/sage/categories/primer.html
I feel like I should do more. I should study it very intently, in order to
be able to explain with the right vocabulary WHY everything related to
categories/parents/elements should be removed from Sage `:-P`
Besides, this example for your docstring is reaaaaaaaallllyyy scary :
{{{
sage: F19 = IntegerModRing(19, category = Fields())
sage: F19.category().is_subcategory(Fields())
True
sage: F23 = IntegerModRing(23)
sage: F23.category().is_subcategory(Fields())
False
sage: F23 in Fields()
True
sage: F23.category().is_subcategory(Fields())
True
}}}
Anyway. I tried to pay very close attention, and all I could spot in your
commit is that I would have written {{{`GF(p) -> Z/pZ`}}} instead of {{{
``GF(p) -> Z/pZ``}}}. Which I guess is only style again `:-P`
Whatever !
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15588#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
