#10255: Correct karatsuba multiplication of univariate polynomials for different
degree polynomials
-------------------------------------+-------------------------------------
Reporter: lftabera | Owner: AlexGhitza
Type: defect | Status: needs_review
Priority: major | Milestone: sage-6.1
Component: basic arithmetic | Resolution:
Keywords: karatsuba, | Merged in:
multiplication, polynomial | Reviewers: Marc Mezzarobba
Authors: Luis Felipe | Work issues:
Tabera Alonso | Commit:
Report Upstream: N/A | 597747007214bdb661d112296f54a77989aa2a01
Branch: | Stopgaps:
u/mmezzarobba/10255-karatsuba |
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by mmezzarobba):
* commit: 15dabc332b766acd7adffad8cfc1371653037831 =>
597747007214bdb661d112296f54a77989aa2a01
* branch: u/lftabera/ticket/10255 => u/mmezzarobba/10255-karatsuba
Comment:
Hi,
I mostly agree with your changes, but I think randomized tests over other
rings than `ZZ` would not be a luxury. So I modified
`test_karatsuba_multiplication` to take the base ring as input. Can you
have a look at my patch?
Most importantly, your test used to compare `g*f` to `f._mul_karatsuba(g,
threshold)`. I changed `g*f` to (essentially) `f*g` in order to handle
noncommutative base rings. But perhaps you wrote `g*f` deliberately? I
also made the degree bound passed to `R.random_element` random. And I
changed `ZZ['x']` to `PolynomialRing(base_ring, 'x')` because some rings
currently don't support the former syntax.
If you are ok with my changes, please go on and set the ticket to
positive_review.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=597747007214bdb661d112296f54a77989aa2a01
5977470]||{{{Improved Karatsuba: more thorough tests}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/10255#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
