#10255: Correct karatsuba multiplication of univariate polynomials for different
degree polynomials
-------------------------------------+-------------------------------------
       Reporter:  lftabera           |        Owner:  AlexGhitza
           Type:  defect             |       Status:  positive_review
       Priority:  major              |    Milestone:  sage-6.1
      Component:  basic arithmetic   |   Resolution:
       Keywords:  karatsuba,         |    Merged in:
  multiplication, polynomial         |    Reviewers:  Marc Mezzarobba, Luis
        Authors:  Luis Felipe        |  Felipe Tabera Alonso
  Tabera Alonso, Marc Mezzarobba     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  597747007214bdb661d112296f54a77989aa2a01
  u/mmezzarobba/10255-karatsuba      |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Luis Felipe Tabera Alonso, Marc Mezzarobba', 
'oldvalue': u'Luis Felipe Tabera Alonso'}):

 * status:  needs_review => positive_review
 * reviewer:  Marc Mezzarobba => Marc Mezzarobba, Luis Felipe Tabera Alonso
 * author:  Luis Felipe Tabera Alonso => Luis Felipe Tabera Alonso, Marc
     Mezzarobba


Comment:

 The code looks good to me. I wrote f._mul_karatsuba thinking on testing
 commutativity, but now I realize that assuming that the other library I am
 testing against is correct, it does not make much sense.

--
Ticket URL: <http://trac.sagemath.org/ticket/10255#comment:29>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to