#13628: refactor xgcd
-------------------------------------+-------------------------------------
Reporter: saraedum | Owner: AlexGhitza
Type: task | Status: needs_review
Priority: trivial | Milestone: sage-6.1
Component: basic arithmetic | Resolution:
Keywords: | Merged in:
Authors: Julian Rueth | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/tscrim/ticket/13628 | 72a598ea4e767523cc843500388f758639daeba6
Dependencies: #13441, #13438 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by niles):
Replying to [comment:11 tscrim]:
> The branch I've attached is based on `develop` (and fixes the merge
conflcit) and has some minor docstring review changes.
Got some failing doctests here; if you fix them I can give positive review
to your changes. (You could also change tuples in the documentation to
use parentheses, which I like too.) Are you giving positive review to the
other parts of the patch?
{{{
sage -t --long src/sage/rings/polynomial/polynomial_quotient_ring.py
**********************************************************************
File "src/sage/rings/polynomial/polynomial_quotient_ring.py", line 254, in
sage.rings.polynomial.polynomial_quotient_ring.PolynomialQuotientRing_generic
Failed example:
[s for s in dir(Q.category().element_class) if not s.startswith('_')]
Expected:
['cartesian_product', 'is_idempotent', 'is_one', 'lift', 'xgcd']
Got:
['cartesian_product', 'is_idempotent', 'is_one', 'is_unit', 'lift']
**********************************************************************
File "src/sage/rings/polynomial/polynomial_quotient_ring.py", line 267, in
sage.rings.polynomial.polynomial_quotient_ring.PolynomialQuotientRing_generic
Failed example:
[s for s in dir(Q.category().element_class) if not s.startswith('_')]
Expected:
['cartesian_product', 'gcd', 'is_idempotent', 'is_one', 'is_unit',
'lcm', 'lift']
Got:
['cartesian_product', 'gcd', 'is_idempotent', 'is_one', 'is_unit',
'lcm', 'lift', 'xgcd']
**********************************************************************
sage -t --long src/sage/rings/integer.pyx
**********************************************************************
File "src/sage/rings/integer.pyx", line 5390, in
sage.rings.integer.Integer._xgcd
Failed example:
-5._xgcd(0, minimal=True)
Exception raised:
Traceback (most recent call last):
...
TypeError: bad operand type for unary -: 'tuple'
**********************************************************************
sage -t --long src/sage/rings/arith.py
**********************************************************************
File "src/sage/rings/arith.py", line 1886, in sage.rings.arith.xgcd
Failed example:
g, a, b = xgcd(5/1, 7/1); g, a, b
Expected:
(1, 3, -2)
Got:
(1, 1/5, 0)
**********************************************************************
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/13628#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
