#13628: refactor xgcd
-------------------------------------+-------------------------------------
Reporter: saraedum | Owner: AlexGhitza
Type: task | Status: needs_review
Priority: trivial | Milestone: sage-6.2
Component: basic arithmetic | Resolution:
Keywords: | Merged in:
Authors: Julian Rueth | Reviewers: Niles Johnson, Travis
Report Upstream: N/A | Scrimshaw
Branch: | Work issues:
u/tscrim/ticket/13628 | Commit:
Dependencies: #13441, #13438 | 5b3ee54bb662e494a7a93f6729b20713412ad6ca
| Stopgaps:
-------------------------------------+-------------------------------------
Changes (by tscrim):
* reviewer: => Niles Johnson, Travis Scrimshaw
Old description:
> Currently, some classes define a _xgcd method which is called by a xgcd
> method of euclidean domain elements. Most elements already define xgcd
> directly, and I see no real use in having this method in between.
>
> The attached patch renames all _xgcd methods to xgcd and also streamlines
> the use of @coerce_binop on them.
>
> This is similar to #13441.
>
> ----
>
> Apply
>
> 1. [[attachment:trac_13628.2.patch]]
New description:
Currently, some classes define a _xgcd method which is called by a xgcd
method of euclidean domain elements. Most elements already define xgcd
directly, and I see no real use in having this method in between.
The attached patch renames all _xgcd methods to xgcd and also streamlines
the use of @coerce_binop on them.
This is similar to #13441.
--
Comment:
Whoops, that typo was from me. I've fixed the MATH block to use
`\mathrm{self}`. If that works for you, then you can set this to positive
review. Thanks.
--
Ticket URL: <http://trac.sagemath.org/ticket/13628#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
