#13628: refactor xgcd
-------------------------------------+-------------------------------------
Reporter: saraedum | Owner: AlexGhitza
Type: task | Status: needs_review
Priority: trivial | Milestone: sage-6.2
Component: basic arithmetic | Resolution:
Keywords: | Merged in:
Authors: Julian Rueth | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/tscrim/ticket/13628 | 2e26b217df37fd113cbdde00a090d4601f508786
Dependencies: #13441, #13438 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by niles):
Thanks for the fixes. Checking the documentation, I found a couple of
problems in `sage.rings.Integer`:
* There is a typo "NOET" in the docstring for `xgcd`
* The MATH blocks for the Bezout identity in `xgcd` and `_xgcd` each have
an extra `\rm`: The syntax `\mbox{\rm self}` renders as "\rm self".
Probably the block can just be replaced with a backtick-quoted line, since
that's what's used in other xgcd docsstrings:
{{{
``g = s * self + t * n``
}}}
* `\rm self` occurs in another line of `_xgcd` docstring, but since this
is an underscore method I don't know how to check the built docstring.
Maybe remove it since the other `\rm`'s caused trouble, but this is a
minor point since no regular user will view the built documentation for
`_xgcd`.
Everything else looks fine, so I can give positive review to the reviewer
patch when these (admittedly annoying) details are fixed.
--
Ticket URL: <http://trac.sagemath.org/ticket/13628#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
