#15735: Add somewhatfptufvs package
-------------------------------------+-------------------------------------
Reporter: spurtuna | Owner: spurtuna
Type: enhancement | Status: new
Priority: minor | Milestone: sage-6.2
Component: PLEASE CHANGE | Resolution:
Keywords: | Merged in:
graph,hard,feedback vertex set | Reviewers:
Authors: spurtuna | Work issues:
Report Upstream: None of the above | Commit:
- read trac for reasoning. | 31b7a2036a17ce63d9b85e9b6ef4e3b2a5de4b3c
Branch: | Stopgaps:
u/spurtuna/15735please |
Dependencies: None |
-------------------------------------+-------------------------------------
Comment (by ncohen):
Hello !
I looked at your Git branch today and at your C code, and what I think is
that it is not ready to be made public. It is messy. Comments, todo, well,
this is your own custom code and you should make it readable for others
before trying to share it. As it is, I would not trust this code myself
unless I read and understand it, and that is beyond me in its current
state. The only way out I see at the moment is to do all the work that it
requires myself, and I cannot give away this amount of time at the moment,
especially without understanding the code.
If you want to share your work, be it by Sage or any other means, please
clean and document your code. Replace "notes to yourself" by "notes that
should be understood by anybody". Don't leave commented code without an
explicit reason.
It would be nice if you could also create a web page somewhere with your
code available on it, explaining how you chose to implement it, which
paper you used, link it to your thesis if you want.
Did you check your code against existing implementation, not for speed but
for correction ?
You can easily do this in Sage, and as you have apparently interfaced it
already you could easily run the following code :
{{{
for g in digraphs(7):
assert g.feedback_vertex_set() == your_feedback_function(g)
}}}
If you already did, please mention it on the web page, if you did not it
would be a good thing to do. All the relevant of your 'readme' file should
probably appear on some page, too.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15735#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/groups/opt_out.
