#15998: Restore some documentation and doctests and a function removed with
#15466
-------------------------------------+-------------------------------------
Reporter: darij | Owner:
Type: defect | Status: needs_info
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Darij Grinberg | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/combinat/re-15466 | 3cda807d8227c794f798a5432289b27200b870cb
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => needs_info
Comment:
Hellooooooo Darij ! I agree with what I see in your patch, but like Travis
I would have tried to obtain this result through `Partitions(n,
length=k).cardinality()`.
I personally hate objects, so I perfectly understand that you may not want
to create all these things if you do not need it, but if you implement it
like that there will be two ways to obtain the same thing, one of which
you would not use yourself because it is too slow.
What would you think of creating this very short class whose cardinality
method would be the function you add ?
Or even better: couldn't you create a cardinality method in the current
"partitions" object, which would either check that "length" is the only
argument and call your function in that case, and otherwise call the
inherited version of "cardinality" (which takes a lifetime anyway ?).
This way, no class to create.
By the way, it seems that this file contains code deprecated by 13072,
which is more than 1 year old.
Have fuuuuuuuuun !
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15998#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
