#15998: Restore some documentation and doctests and a function removed with
#15466
-------------------------------------+-------------------------------------
Reporter: darij | Owner:
Type: defect | Status: needs_info
Priority: major | Milestone: sage-6.2
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Darij Grinberg | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/combinat/re-15466 | 1c4454fad5d281acb2f5d51e57182cef16829e2d
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* status: needs_review => needs_info
Comment:
Helloooooooooooooooooooooooooooo !!
Too bad. I was getting into your ZS1 algorithm which I had never read, and
I ended up wondering if you really needed to re-implement it, i.e. if you
could not remove this part of your patch `:-P`
You are writing an iterator over the partitions of n of length exactly k.
Do you agree with me if I say that it is equivalent to iterating over the
partitions of n-k of length *at most* k ?
Because you already have a way to get all partitions of length at most k :
ZS1 as it is currently implemented does it, doesn't it ? You just have to
stop iterating when the partition has length >k.
So well, tell me what you think of it.
I have other comments :
- "Fast Algorithms for Generating Integer Partitons" should be in a
REFERENCE block, and cited as we usually cite references (see sage:
`Graph.modular_decomposition??`)
- You define Fubini numbers and link to their OEIS page. Could you link to
this page too ? http://en.wikipedia.org/wiki/Ordered_Bell_number
- In the doc of ZS1 there is a "partition type" : was "partition tuples"
intended ?
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/15998#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
