#10745: bug in elliptic curve gens()
-------------------------------------+-------------------------------------
       Reporter:  rlm                |        Owner:  cremona
           Type:  defect             |       Status:  positive_review
       Priority:  major              |    Milestone:
      Component:  elliptic curves    |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Peter Bruin        |    Reviewers:  Chris Wuthrich
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/pbruin/10745-elliptic_curve_gens |  42c563c4b4e834adb39d75b3b02e21ab1c3da372
   Dependencies:  #10735             |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by wuthrich):

 * status:  needs_review => positive_review
 * reviewer:   => Chris Wuthrich


Comment:

 OK, that was helpful.

 All tests pass and I am happy with all modifications. Except there is one
 I am not certain about. You changed in gp_simon that the model is not
 necessarily changed to an integral model. I tried a few example and it
 seems to work even with non-integral models. Why are you certain this will
 never cause a problem ?

 Can I leave you to open a ticket for the other issue on gens ? I believe
 there is one for saturation, but I think we should open another one for
 the original problem posted in the question here.

--
Ticket URL: <http://trac.sagemath.org/ticket/10745#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to