#10745: bug in elliptic curve gens()
-------------------------------------+-------------------------------------
Reporter: rlm | Owner: cremona
Type: defect | Status: positive_review
Priority: major | Milestone:
Component: elliptic curves | Resolution:
Keywords: | Merged in:
Authors: Peter Bruin | Reviewers: Chris Wuthrich
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/pbruin/10745-elliptic_curve_gens | 42c563c4b4e834adb39d75b3b02e21ab1c3da372
Dependencies: #10735 | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by pbruin):
Replying to [comment:22 wuthrich]:
> All tests pass and I am happy with all modifications.
Thanks for the review!
>Except there is one I am not certain about. You changed in gp_simon that
the model is not necessarily changed to an integral model. I tried a few
example and it seems to work even with non-integral models. Why are you
certain this will never cause a problem ?
Denis Simon writes this in the documentation of `ell.gp`:
{{{
La fonction bnfellrank() accepte toutes les courbes sous la forme
[a1,a2,a3,a4,a6]
Les coefficients peuvent etre entiers ou non.
}}}
One of the first things that the GP function `bnfellrank()` does is indeed
clearing denominators. (The specialised functions for the three possible
2-torsion structures do require an integral model, but we don't call those
directly.)
> Can I leave you to open a ticket for the other issue on gens ? I believe
there is one for saturation, but I think we should open another one for
the original problem posted in the question here.
You mean for extracting a set of linearly independent points, or for the
trick of looking over smaller fields first? I can open a ticket for each
of those. The one for saturation is #8829.
--
Ticket URL: <http://trac.sagemath.org/ticket/10745#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
