#15781: Increase Performance of possible_periods in Projective Morphism
-------------------------------------+-------------------------------------
Reporter: drose | Owner: drose
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-6.2
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: possible_periods, | Reviewers: Ben Hutz
cython | Work issues:
Authors: Dillon Rose | Commit:
Report Upstream: N/A | 89da33337ecac6d43c7b3da4b37e8dc1a9ad16ee
Branch: | Stopgaps:
u/drose/ticket/15781 |
Dependencies: #15780 |
-------------------------------------+-------------------------------------
Changes (by bhutz):
* status: needs_review => needs_work
* reviewer: => Ben Hutz
Comment:
No issues with the long test, but before I do more specialized testing
there are number of things from looking through the code:
1) Fix preamble documentation to be for the helper and not generic
projective space
2) Fix copyright date
3) in _fast_possible_periods:
- use a Reference block - see dynamtomic_polynomial (should be able to
use the references from other files)
- examples should call _fast_possible_periods
- todo: typo return
- todo: add - more space efficient hash/pointtable
- use is_prime_finite_field
- move import to header of file
4) pass N+1 into into _normalize_coordinates to replace the len(point)
calls
5) _mod_inv - description: Find the inverse of the number modulo the given
prime.
6) Use the better version of the eigenvale computation (see 14219 lines
2608-2624)
7) also from 14219
use
return sorted(periods)
instead of
periods=list(periods)
periods.sort()
return(periods)
8)enum points documentation:
Enumerate points in projective space over finite field with given prime
and dimension.
--
Ticket URL: <http://trac.sagemath.org/ticket/15781#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
