#16275: Hom: introduce a check argument to simplify the unpickling detection
logic
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: sage-6.2
Component: categories | Resolution:
Keywords: homset, pickling | Merged in:
Authors: Nicolas M. Thiéry | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/nthiery/hom__introduce_a_check_argument_to_simplify_the_unpickling_detection_logic|
507ee00f4f1f81680a52cd798d2fd5a03fb4172d
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by SimonKing):
I am puzzled. I have pulled from your branch. Then I have added a commit,
and tried `git trac push` and `git push`. The former failed without
telling me why. The latter failed, and told me
{{{
To [email protected]:sage.git
! [rejected]
t/16275/hom__introduce_a_check_argument_to_simplify_the_unpickling_detection_logic
->
u/SimonKing/hom__introduce_a_check_argument_to_simplify_the_unpickling_detection_logic
(non-fast-forward)
error: Fehler beim Versenden einiger Referenzen nach
'[email protected]:sage.git'
Hinweis: Aktualisierungen wurden zurückgewiesen, weil die Spitze eines
versendeten
Hinweis: Zweiges hinter seinem externen Gegenstück zurückgefallen ist.
Checke diesen
Hinweis: Zweig aus und führe die externen Änderungen zusammen (z.B. 'git
pull')
Hinweis: bevor du erneut versendest.
Hinweis: Siehe auch die Sektion 'Note about fast-forwards' in 'git push
--help'
Hinweis: für weitere Details.
}}}
In other words, it claims that my branch tip is BEHIND the tip of the
current branch here. But this is not the case! I did pull before
committing, and here is the log:
{{{
* 76bdaa9 - (HEAD,
t/16275/hom__introduce_a_check_argument_to_simplify_the_unpickling_detection_logic)
Make it so that old homset pickles remain unpicklable (vor 4 Minuten)
<Simon King>
* 507ee00 - Trac 16275: fixes for the previous commit; btw its title
should have read: removed sage.modular.abvar.homspace.Homspace.__reduce__
(vor 12 Minuten) <Nicolas M. Thiéry>
* ae3ca80 - This is handled as well by the generic of Homset.__reduce__
method, and the latter takes care of setting check=False as needed. (vor 4
Stunden) <Nicolas M. Thiéry>
* c1e91f3 - #16275: update ticket number in the comments (vor 4 Stunden)
<Nicolas M. Thiéry>
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/16275#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
