#16275: Hom: introduce a check argument to simplify the unpickling detection
logic
-------------------------------------+-------------------------------------
Reporter: nthiery | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-6.2
Component: categories | Resolution:
Keywords: homset, pickling | Merged in:
Authors: Nicolas M. Thiéry | Reviewers: Simon King
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/SimonKing/ticket/16275 | ecc4616852de61a3f1fa62bdf9dc76a61d94aaba
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by nthiery):
"belonging -> belongs" in the code comment. Other than that your commit
looks good. Thanks!
What about including the pickle directly as a string in the docttest (or
possibly in the code)? I think we have already done this on some other
occasion, and this sounds appropriate to point out: ``we want this
specific pickle to work'', rather than ``this is tested by some pickle out
there in the pickle jar; go search for it if you want to reproduce the
potential problem''.
Ah, yes, there remains to add a little ref to the ticket in the code
comments. Do you want me to do it?
--
Ticket URL: <http://trac.sagemath.org/ticket/16275#comment:33>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
